Re: [PATCH 4/4] arm: dts: owl-s500: Add RoseapplePi

From: Cristian Ciocaltea
Date: Thu Aug 27 2020 - 10:36:00 EST


Hi Peter,

Thanks for the review!

On Thu, Aug 27, 2020 at 08:44:40AM +0200, Peter Korsgaard wrote:
> >>>>> "Cristian" == Cristian Ciocaltea <cristian.ciocaltea@xxxxxxxxx> writes:
>
> > Add a Device Tree for the RoseapplePi SBC.
> > Signed-off-by: Cristian Ciocaltea <cristian.ciocaltea@xxxxxxxxx>
>
> Reviewed-by: Peter Korsgaard <peter@xxxxxxxxxxxxx>
>
> On a related note: There is now an owl-mmc driver for the s900. From a
> quick look at the datasheet it looks compatible with the controller on
> the s500. Did you have a look at hooking that up?

Yes, please see:
https://lore.kernel.org/lkml/cover.1593124368.git.cristian.ciocaltea@xxxxxxxxx/

The clock related patches have been already applied to v5.9 and
hopefully the pinctrl driver will follow in v5.10.

> --
> Bye, Peter Korsgaard

Regards,
Cristi