Re: [PATCH] net: Add 'else' to split mutually exclusive case

From: David Miller
Date: Thu Aug 27 2020 - 12:10:59 EST

Next message: David Miller: "Re: [PATCH] net: Call ip_hdrlen() when skbuff is not fragment"
Previous message: Greg Kroah-Hartman: "Re: [PATCH] MAINTAINERS: Add security docs to SECURITY CONTACT"
In reply to: Miaohe Lin: "[PATCH] net: Add 'else' to split mutually exclusive case"
Messages sorted by: [ date ] [ thread ] [ subject ] [ author ]

From: Miaohe Lin <linmiaohe@xxxxxxxxxx>
Date: Thu, 27 Aug 2020 07:15:52 -0400

> Add else to split mutually exclusive case and avoid unnecessary check.
>
> Signed-off-by: Miaohe Lin <linmiaohe@xxxxxxxxxx>

I see no value to this, the compiler is doing the right thing already
and this does not add to code readability either.

I'm not applying this, sorry.

Next message: David Miller: "Re: [PATCH] net: Call ip_hdrlen() when skbuff is not fragment"
Previous message: Greg Kroah-Hartman: "Re: [PATCH] MAINTAINERS: Add security docs to SECURITY CONTACT"
In reply to: Miaohe Lin: "[PATCH] net: Add 'else' to split mutually exclusive case"
Messages sorted by: [ date ] [ thread ] [ subject ] [ author ]