Re: [PATCH] net: Call ip_hdrlen() when skbuff is not fragment

From: David Miller
Date: Thu Aug 27 2020 - 12:11:53 EST


From: Miaohe Lin <linmiaohe@xxxxxxxxxx>
Date: Thu, 27 Aug 2020 07:17:59 -0400

> When skbuff is fragment, we exit immediately and leave ip_hdrlen() as
> unused. And remove the unnecessary local variable fragment.
>
> Signed-off-by: Miaohe Lin <linmiaohe@xxxxxxxxxx>

I don't think this is a useful optimization sorry, the common case
will be just as likely to be a fragment as not so it's arbitrary
whether we read this simple value or not.

I'm not applying this, sorry.