Re: [PATCH 3/3] mmc: s3cmci: Cast driver data through long

From: Ulf Hansson
Date: Thu Sep 03 2020 - 04:11:54 EST


On Wed, 2 Sep 2020 at 22:49, Krzysztof Kozlowski <krzk@xxxxxxxxxx> wrote:
>
> Since driver data is a pointer, direct casting to integer causes
> warning when compile testing for 64-bit architecture:
>
> drivers/mmc/host/s3cmci.c:1495:17: warning: cast from pointer to integer of different size [-Wpointer-to-int-cast]
>
> The actual driver data can be only 0 or 1, so cast it via long and do
> not care about any loss of value.
>
> Signed-off-by: Krzysztof Kozlowski <krzk@xxxxxxxxxx>

Applied for next, thanks!

Kind regards
Uffe


> ---
> drivers/mmc/host/s3cmci.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/mmc/host/s3cmci.c b/drivers/mmc/host/s3cmci.c
> index 3fb597095079..ac94f926624d 100644
> --- a/drivers/mmc/host/s3cmci.c
> +++ b/drivers/mmc/host/s3cmci.c
> @@ -1492,7 +1492,7 @@ static int s3cmci_probe_dt(struct s3cmci_host *host)
> struct mmc_host *mmc = host->mmc;
> int ret;
>
> - host->is2440 = (int) of_device_get_match_data(&pdev->dev);
> + host->is2440 = (long) of_device_get_match_data(&pdev->dev);
>
> ret = mmc_of_parse(mmc);
> if (ret)
> --
> 2.17.1
>