Re: [PATCH v3 3/7] ASoC: sun4i-i2s: Add support for H6 I2S
From: Maxime Ripard
Date: Thu Sep 03 2020 - 16:59:02 EST
On Thu, Sep 03, 2020 at 10:02:31PM +0200, Clément Péron wrote:
> Hi Maxime,
>
> On Wed, 29 Jul 2020 at 17:16, Mark Brown <broonie@xxxxxxxxxx> wrote:
> >
> > On Wed, Jul 29, 2020 at 04:39:27PM +0200, Maxime Ripard wrote:
> >
> > > It really looks like the polarity of LRCK is fine though. The first word
> > > is sent with LRCK low, and then high, so we have channel 0 and then
> > > channel 1 which seems to be the proper ordering?
> >
> > Yes, that's normal.
>
> Thank you very much for this test.
>
> So I will revert the following commit:
>
> ASoC: sun4i-i2s: Fix the LRCK polarity
>
> https://github.com/clementperon/linux/commit/dd657eae8164f7e4bafe8b875031a7c6c50646a9
Like I said, the current code is working as expected with regard to the
LRCK polarity. The issue is that the samples are delayed and start to be
transmitted on the wrong phase of the signal.
But the LRCK polarity is fine.
Maxime
Attachment:
signature.asc
Description: PGP signature