Re: [PATCH] arm64/mm/ptdump: Add address markers for BPF regions

[Steven Price]

On 04/09/2020 09:30, Anshuman Khandual wrote:
> Kernel virtual region [BPF_JIT_REGION_START..BPF_JIT_REGION_END] is missing
> from address_markers[], hence relevant page table entries are not displayed
> with /sys/kernel/debug/kernel_page_tables. This adds those missing markers.
> While here, also rename arch/arm64/mm/dump.c which sounds bit ambiguous, as
> arch/arm64/mm/ptdump.c instead.
>
> Cc: Catalin Marinas <catalin.marinas@xxxxxxx>
> Cc: Will Deacon <will@xxxxxxxxxx>
> Cc: Ard Biesheuvel <ardb@xxxxxxxxxx>
> Cc: Steven Price <steven.price@xxxxxxx>
> Cc: Andrew Morton <akpm@xxxxxxxxxxxxxxxxxxxx>
> Cc: linux-arm-kernel@xxxxxxxxxxxxxxxxxxx
> Cc: linux-kernel@xxxxxxxxxxxxxxx
> Signed-off-by: Anshuman Khandual <anshuman.khandual@xxxxxxx>

LGTM

Reviewed-by: Steven Price <steven.price@xxxxxxx>

> ---
>   arch/arm64/mm/Makefile             | 2 +-
>   arch/arm64/mm/{dump.c => ptdump.c} | 2 ++
>   2 files changed, 3 insertions(+), 1 deletion(-)
>   rename arch/arm64/mm/{dump.c => ptdump.c} (99%)
>
> diff --git a/arch/arm64/mm/Makefile b/arch/arm64/mm/Makefile
> index d91030f0ffee..2a1d275cd4d7 100644
> --- a/arch/arm64/mm/Makefile
> +++ b/arch/arm64/mm/Makefile
> @@ -4,7 +4,7 @@ obj-y				:= dma-mapping.o extable.o fault.o init.o \
>   				   ioremap.o mmap.o pgd.o mmu.o \
>   				   context.o proc.o pageattr.o
>   obj-$(CONFIG_HUGETLB_PAGE)	+= hugetlbpage.o
> -obj-$(CONFIG_PTDUMP_CORE)	+= dump.o
> +obj-$(CONFIG_PTDUMP_CORE)	+= ptdump.o
>   obj-$(CONFIG_PTDUMP_DEBUGFS)	+= ptdump_debugfs.o
>   obj-$(CONFIG_NUMA)		+= numa.o
>   obj-$(CONFIG_DEBUG_VIRTUAL)	+= physaddr.o
> diff --git a/arch/arm64/mm/dump.c b/arch/arm64/mm/ptdump.c
> similarity index 99%
> rename from arch/arm64/mm/dump.c
> rename to arch/arm64/mm/ptdump.c
> index 0b8da1cc1c07..265284dc942d 100644
> --- a/arch/arm64/mm/dump.c
> +++ b/arch/arm64/mm/ptdump.c
> @@ -41,6 +41,8 @@ static struct addr_marker address_markers[] = {
>   	{ 0 /* KASAN_SHADOW_START */,	"Kasan shadow start" },
>   	{ KASAN_SHADOW_END,		"Kasan shadow end" },
>   #endif
> +	{ BPF_JIT_REGION_START,		"BPF start" },
> +	{ BPF_JIT_REGION_END,		"BPF end" },
>   	{ MODULES_VADDR,		"Modules start" },
>   	{ MODULES_END,			"Modules end" },
>   	{ VMALLOC_START,		"vmalloc() area" },