Re: remove set_fs for riscv
From: Arnd Bergmann
Date: Mon Sep 07 2020 - 11:09:07 EST
On Mon, Sep 7, 2020 at 8:03 AM Christoph Hellwig <hch@xxxxxx> wrote:
>
> On Mon, Sep 07, 2020 at 12:14:59AM +0200, Arnd Bergmann wrote:
> > I've had a first pass at this now, see
> >
> > https://git.kernel.org/pub/scm/linux/kernel/git/arnd/playground.git/log/?h=arm-kill-set_fs
> >
> > There are a couple of things in there that ended up uglier than I was
> > hoping for, and it's completely untested beyond compilation. Is this
> > roughly what you had in mind? I can do some testing then and post
> > it to the Arm mailing list.
>
> Looks sensible. The OABI hacks a are a little ugly, but so would be
> every other alternative.
Ok, thanks for taking a look. I've now managed to run the patched
kernel with OABI user space and tested the modified syscalls with
LTP. The 0-day bot found a regression that I have fixed.
I'll send out the series for review next.
> Note that you don't need to add a TASK_SIZE_MAX definition to arm if you
> base it on my series as that provides a default one.
I've rebased on that patch now and taken out those definitions.
> I also think with these changes arm/nommu should be able to use
> UACCESS_MEMCPY.
Probably yes, but I'd leave the current version for now. The Arm
implementation already supports combinations of range check
and domain settings, with the NOMMU targets using neither, but
sharing the same implementation as the others.
Arnd