Re: [PATCH v2 3/7] mm/memory_hotplug: prepare passing flags to add_memory() and friends

From: David Hildenbrand
Date: Wed Sep 09 2020 - 03:29:26 EST

On 09.09.20 09:17, Greg Kroah-Hartman wrote:
> On Tue, Sep 08, 2020 at 10:10:08PM +0200, David Hildenbrand wrote:
>> We soon want to pass flags, e.g., to mark added System RAM resources.
>> mergeable. Prepare for that.
> What are these random "flags", and how do we know what should be passed
> to them?
> Why not make this an enumerated type so that we know it all works
> properly, like the GPF_* flags are? Passing around a random unsigned
> long feels very odd/broken...

Agreed, an enum (mhp_flags) seems to give a better hint what can
actually be passed. Thanks!


David / dhildenb