Re: [PATCH V5 2/4] arm64: dts: qcom: sc7180: Add necessary pinctrl and interrupt config for BT UART

[skakit]

On 2020-09-10 20:10, Doug Anderson wrote:
> Hi,
>
> On Thu, Sep 10, 2020 at 5:55 AM satya priya <skakit@xxxxxxxxxxxxxx> 
> wrote:
> > Add a suitable sleep configuration for uart3 to support Bluetooth 
> > wakeup.
> >
> > If QUP function is selected in sleep state, UART RTS/RFR is pulled 
> > high
> > during suspend and BT SoC not able to send wakeup bytes. So, configure
> > GPIO mode in sleep state to keep it low during suspend.
> >
> > Signed-off-by: satya priya <skakit@xxxxxxxxxxxxxx>
> > Reviewed-by: Akash Asthana <akashast@xxxxxxxxxxxxxx>
> > ---
> > Changes in V2:
> >  - This patch adds sleep state for BT UART. Newly added in V2.
> >
> > Changes in V3:
> >  - Remove "output-high" for TX from both sleep and default states
> >    as it is not required. Configure pull-up for TX in sleep state.
> >
> > Changes in V4:
> >  - As per Matthias's comment, removed drive-strength for sleep state
> >    and fixed nit-pick.
> >
> > Changes in V5:
> >  - As per Matthias's comments, moved pinmux change for sleep state,
> >    pinctrl and interrupt config to the board specific file.
> >
> >  arch/arm64/boot/dts/qcom/sc7180-idp.dts | 48 
> > +++++++++++++++++++++++++++++++++
> >  1 file changed, 48 insertions(+)
>
> Similar comment to patch #1 in that this applies only to the IDP board
> but that's not obvious from ${SUBJECT}

Okay.

> > diff --git a/arch/arm64/boot/dts/qcom/sc7180-idp.dts 
> > b/arch/arm64/boot/dts/qcom/sc7180-idp.dts
> > index 04888df..e529a41 100644
> > --- a/arch/arm64/boot/dts/qcom/sc7180-idp.dts
> > +++ b/arch/arm64/boot/dts/qcom/sc7180-idp.dts
> > @@ -344,6 +344,10 @@
> >  };
> >
> >  &uart3 {
> > +       pinctrl-names = "default", "sleep";
> > +       pinctrl-1 = <&qup_uart3_sleep>;
> > +       interrupts-extended = <&intc GIC_SPI 604 IRQ_TYPE_LEVEL_HIGH>,
> > +                               <&tlmm 41 IRQ_TYPE_EDGE_FALLING>;
>
> You need a:
>
> /delete-property/interrupts;
>
> ...or, alternatively, a patch before this one that converts all the
> UARTs in sc7180 to just use interrupts-extended.

Sure, I will add this. But I think when both are added, 
"interrupts-extended" will get priority as per [1] and there wouldn't be 
any problem.

[1] 
https://www.kernel.org/doc/Documentation/devicetree/bindings/interrupt-controller/interrupts.txt

> >         status = "okay";
>
> Slight nit is that usually I see the status line first.  All the other
> instances in this file have it that way.  Can you match?

Ok, will correct it.

> -Doug