Re: [PATCH v2] nfs: remove incorrect fallthrough label

From: linmiaohe
Date: Thu Sep 17 2020 - 02:21:23 EST

Nick Desaulniers <ndesaulniers@xxxxxxxxxx> wrote:
> There is no case after the default from which to fallthrough to. Clang will error in this case (unhelpfully without context, see link below) and GCC will with -Wswitch-unreachable.
>The previous commit should have just replaced the comment with a break statement.
>If we consider implicit fallthrough to be a design mistake of C, then all case statements should be terminated with one of the following
>* break
>* continue
>* return
>* __attribute__(__fallthrough__)
>* goto (plz no)
>* (call of function with __attribute__(__noreturn__))
>Fixes: 2a1390c95a69 ("nfs: Convert to use the preferred fallthrough macro")
>Suggested-by: Joe Perches <joe@xxxxxxxxxxx>
>Signed-off-by: Nick Desaulniers <ndesaulniers@xxxxxxxxxx>

Reviewed-by: Miaohe Lin <linmiaohe@xxxxxxxxxx>