Re: [PATCHv3] perf kvm: add kvm-stat for arm64

[Marc Zyngier]

On 2020-09-18 01:32, Sergey Senozhatsky wrote:
> On (20/09/17 12:53), Marc Zyngier wrote:
> > Feel free to add a *new* tracepoint instead.
>
> Wouldn't we want a whole bunch of new tracepoints in this case?

Yes. I don't have a better solution as long as tracepoints are ABI.
Get someone to sign-off on it, and I'll happily change them.

> (almost all of the existing ones with the extra vcpu_id field).
> Right now we have 3 types of events:
> - events with no vcpu at all        // nil
> - events with vcpu_pc               // "0x%016lx", __entry->vcpu_pc
> - events with (void *)vcpu          // "vcpu: %p", __entry->vcpu
>
> It might be helpful if we could filter out events by vcpu_id.
> But this, basically, doubles the number of events in the ringbuffer.

Only if you enable them both, right? You define new tracepoints that
do whatever you need them to do (hopefully in a cross-architecture
compliant way), and have perf to only use the new ones on arm64.
How would that double the number of events in the buffer?

        M.
--
Jazz is not dead. It just smells funny...