Re: linux-next: Tree for Sep 17 (net/ipv4/devinet.c)

From: Stephen Rothwell
Date: Fri Sep 18 2020 - 04:37:26 EST


Hi Randy,

On Thu, 17 Sep 2020 13:45:52 -0700 Randy Dunlap <rdunlap@xxxxxxxxxxxxx> wrote:
>
> Maybe some older versions of gcc just can't handle IS_ENABLED() inside an
> if (expression) very well.
>
> > gcc --version
> gcc (SUSE Linux) 7.5.0
>
> This patch:
>
> commit 9efd6a3cecdde984d67e63d17fe6af53c7c50968
> Author: Nicolas Dichtel <nicolas.dichtel@xxxxxxxxx>
> Date: Wed May 13 15:58:43 2020 +0200
>
> netns: enable to inherit devconf from current netns
>
> causes a build error:
>
> ../net/ipv4/devinet.c: In function ‘devinet_init_net’:
> ../net/ipv4/devinet.c:2672:7: error: ‘sysctl_devconf_inherit_init_net’ undeclared (first use in this function); did you mean ‘devinet_init_net’?
> sysctl_devconf_inherit_init_net == 3) {
> ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
> devinet_init_net
> ../net/ipv4/devinet.c:2672:7: note: each undeclared identifier is reported only

With your config, can you try creating net/ipv4/devinet.i (preprocessed) file and
see if sysctl_devconf_inherit_init_net is actually declared? I
couldn't see any obvious way it is not, but that would explain the
error.

--
Cheers,
Stephen Rothwell

Attachment: pgpiD86i1Hv1R.pgp
Description: OpenPGP digital signature