Re: linux-next: Tree for Sep 17 (net/ipv4/devinet.c)

[Randy Dunlap]

On 9/18/20 1:25 AM, Nicolas Dichtel wrote:
> Le 17/09/2020 à 22:45, Randy Dunlap a écrit :
>> On 9/17/20 3:23 AM, Stephen Rothwell wrote:
>>> Hi all,
>>>
>>> Changes since 20200916:
>>>
>>
>>
>> Maybe some older versions of gcc just can't handle IS_ENABLED() inside an
>> if (expression) very well.
>>
>>> gcc --version
>> gcc (SUSE Linux) 7.5.0


> I tried with a (very old) gcc and I did not reproduce this error:
> $ gcc --version
> gcc (Debian 4.9.2-10+deb8u2) 4.9.2
> 

OK, no problem then.
I cannot reproduce it now either (I just tried 3-4 times).
We can forget about it. Sorry for the noise.

> 
>>
>> This patch:
>>
>> commit 9efd6a3cecdde984d67e63d17fe6af53c7c50968
>> Author: Nicolas Dichtel <nicolas.dichtel@xxxxxxxxx>
>> Date:   Wed May 13 15:58:43 2020 +0200
>>
>>     netns: enable to inherit devconf from current netns
>>
>> causes a build error:
>>
>> ../net/ipv4/devinet.c: In function ‘devinet_init_net’:
>> ../net/ipv4/devinet.c:2672:7: error: ‘sysctl_devconf_inherit_init_net’ undeclared (first use in this function); did you mean ‘devinet_init_net’?
>>        sysctl_devconf_inherit_init_net == 3) {
>>        ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
>>        devinet_init_net
>> ../net/ipv4/devinet.c:2672:7: note: each undeclared identifier is reported only
>>
>>

thanks.
-- 
~Randy