RE: [PATCH v5 02/10] fs/ntfs3: Add initialization of super block

[Konstantin Komarov]

From: Mark Harmstone <mark.harmstone@xxxxxxxxx> On Behalf Of Mark Harmstone
Sent: Friday, September 11, 2020 7:50 PM
> Subject: Re: [PATCH v5 02/10] fs/ntfs3: Add initialization of super block
> 
> Also, I think it would be a good idea if you *are* going to have static SDs, to
> allocate them dynamically rather than using a blob. The blobs' contents don't
> match your comments,

Hi Mark! Fixed the comment thing. Check out the V6.
V6 also introduces the system.ntfs_security xattr.

>and it'd have been picked up if you'd done that!
> 
> s_dir_security translates to:
> owner S-1-5-32-544 (Administrators)
> group S-1-5-32-544 (Administrators)
> ACE: allow S-1-1-0 (Everyone) with FILE_ALL_ACCESS
> 
> s_file_security translates to:
> owner S-1-1-0 (Everyone)
> group S-1-5-21-1987932187-4155540637-3944497785-513 (your personal SID?!)
> ACE: allow S-1-1-0 (Everyone) with FILE_ALL_ACCESS
> 
> 
> On 11/9/20 3:10 pm, Konstantin Komarov wrote:
> > This adds initialization of super block
> >
[]
> > +}
> > +
> > +MODULE_LICENSE("GPL");
> > +MODULE_DESCRIPTION("ntfs3 filesystem");
> > +MODULE_AUTHOR("Konstantin Komarov");
> > +MODULE_ALIAS_FS("ntfs3");
> > +
> > +module_init(init_ntfs_fs) module_exit(exit_ntfs_fs)
> 

Thanks