Re: [PATCH v2 3/4] mm: introduce page memcg flags

[Shakeel Butt]

On Thu, Sep 24, 2020 at 12:29 PM Roman Gushchin <guro@xxxxxx> wrote:
>
> The lowest bit in page->memcg_data is used to distinguish between
> struct memory_cgroup pointer and a pointer to a objcgs array.
> All checks and modifications of this bit are open-coded.
>
> Let's formalize it using page memcg flags, defined in page_memcg_flags
> enum, and replace all open-coded accesses with test_bit()/__set_bit().
>
> Additional flags might be added later.
>
> Signed-off-by: Roman Gushchin <guro@xxxxxx>

Thanks.

Reviewed-by: Shakeel Butt <shakeelb@xxxxxxxxxx>