Re: [PATCH v2 04/11] drivers/base/devcoredump: convert devcd_count to counter_atomic32

From: Kees Cook
Date: Thu Oct 08 2020 - 03:37:07 EST


On Thu, Oct 08, 2020 at 08:42:22AM +0200, Johannes Berg wrote:
> 1) each value that we derive from this ever-incrementing (modulo 2^32)
> variable only get used for a limited amount of time (max. 5 minutes)

Ah! That's what I misunderstood, the resulting value is only used for 5
minutes. Got it; thanks!

> IOW, I disagree with you, and think that counter_atomic_32 is more
> appropriate here than refcount_t.

I agree now! :)

--
Kees Cook