Re: [PATCH v2] MIPS: replace add_memory_region with memblock

From: Jiaxun Yang
Date: Thu Oct 08 2020 - 23:01:00 EST




在 2020/10/8 23:20, Serge Semin 写道:

[...]

- add_memory_region(LOONGSON_HIGHMEM_START,
- highmemsize << 20, BOOT_MEM_RAM);
-
- add_memory_region(LOONGSON_PCI_MEM_END + 1, LOONGSON_HIGHMEM_START -
- LOONGSON_PCI_MEM_END - 1, BOOT_MEM_RESERVED);
-
+ memblock_add(LOONGSON_HIGHMEM_START, highmemsize << 20);
The same question. Is it ok to discard the
[LOONGSON_PCI_MEM_END+1:LOONGSON_HIGHMEM_START-LOONGSON_PCI_MEM_END-1] region
removal operation?
Hi all,

I can confirm this reservation can be removed.
It was used to ensure HIGHMEM won't overlap PCI MMIO region when
firmware was unreliable.
But I do think we shouldn't care this case as an unreliable firmware shouldn't
ship with any devices for end users.

Also it won't affect display of /proc/iomem, now we're on age of DeviceTree :-)

Thanks.

- Jiaxun


-Sergey

#endif /* !CONFIG_64BIT */
}