Re: [PATCH v2 10/11] soc: ti: k3-ringacc: Use correct device for allocation in RING mode

From: Nishanth Menon
Date: Thu Oct 08 2020 - 23:02:12 EST


On 14:52-20201008, Peter Ujfalusi wrote:
> - ring->ring_mem_virt = dma_alloc_coherent(ringacc->dev,
> + ring->ring_mem_virt = dma_alloc_coherent(ring->dma_dev,
> ring->size * (4 << ring->elm_size),
> &ring->ring_mem_dma, GFP_KERNEL);

Any chance of getting a cleanup of the file for 5.11? I know this series
has'nt introduced this warning or set of warnings, but I am starting to
get concerned that we are carrying over too much of a debt now?

https://pastebin.ubuntu.com/p/tT2kPDsCWD/

Checkpatch does point this:

--- /tmp/kernel-patch-verify.25812/ptest_check-start 2020-10-08
19:33:31.025898581 +0000
+++ /tmp/kernel-patch-verify.25812/ptest_check-end 2020-10-08
19:33:31.593893830 +0000
@@ -0,0 +1,6 @@
+CHECK: Alignment should match open parenthesis
+#84: FILE: drivers/soc/ti/k3-ringacc.c:657:
++ ring->ring_mem_virt = dma_alloc_coherent(ring->dma_dev,
+ ring->size * (4 << ring->elm_size),

--
Regards,
Nishanth Menon
Key (0xDDB5849D1736249D) / Fingerprint: F8A2 8693 54EB 8232 17A3 1A34 DDB5 849D 1736 249D