Re: [PATCH] mtd: hyperbus: Fix build failure when only RPCIF_HYPERBUS is enabled
From: Richard Weinberger
Date: Mon Oct 12 2020 - 15:17:27 EST
----- Ursprüngliche Mail -----
> Von: "Vignesh Raghavendra" <vigneshr@xxxxxx>
> An: "Vignesh Raghavendra" <vigneshr@xxxxxx>, "Miquel Raynal" <miquel.raynal@xxxxxxxxxxx>, "richard" <richard@xxxxxx>
> CC: "Sergei Shtylyov" <sergei.shtylyov@xxxxxxxxx>, "linux-mtd" <linux-mtd@xxxxxxxxxxxxxxxxxxx>, "linux-kernel"
> <linux-kernel@xxxxxxxxxxxxxxx>
> Gesendet: Montag, 12. Oktober 2020 09:09:58
> Betreff: [PATCH] mtd: hyperbus: Fix build failure when only RPCIF_HYPERBUS is enabled
> commit 5de15b610f78 ("mtd: hyperbus: add Renesas RPC-IF driver") leads
> to build failure[1] with COMPILE_TEST and RPCIF_HYPERBUS enabled. This
> is because driver needs functions RENESAS_RPCIF which is only buildable
> for CONFIG_ARCH_RENESAS.
>
> Fix this by dropping COMPILE_TEST from RPCIF_HYPERBUS Kconfig entry.
> This ensures driver can be built only when RENESAS_RPCIF is also
> selected.
>
> [1]:
> rpc-if.c:(.text+0x20): undefined reference to `rpcif_disable_rpm' ld:
> drivers/mtd/hyperbus/rpc-if.o: in function `rpcif_hb_prepare_read':
> rpc-if.c:(.text+0xd6): undefined reference to `rpcif_prepare' ld:
> drivers/mtd/hyperbus/rpc-if.o: in function `rpcif_hb_read16':
> [...]
>
> Fixes: 5de15b610f78 ("mtd: hyperbus: add Renesas RPC-IF driver") leads
> Reported-by: Richard Weinberger <richard@xxxxxx>
> Signed-off-by: Vignesh Raghavendra <vigneshr@xxxxxx>
> ---
>
> Based on mtd/next
>
> Richard,
>
> Could you please pull this into mtd/next?
Applied! :-)
Thanks,
//richard