Re: [PATCH 3/6] spi: dt-bindings: spi-controller: explicitly require #address-cells=<0> for slave mode
From: Rob Herring
Date: Wed Oct 14 2020 - 09:41:56 EST
On Wed, 14 Oct 2020 00:08:42 +0800, Zhen Lei wrote:
> scripts/dtc/checks.c:
> if (get_property(node, "spi-slave"))
> spi_addr_cells = 0;
> if (node_addr_cells(node) != spi_addr_cells)
> FAIL(c, dti, node, "incorrect #address-cells for SPI bus");
> if (node_size_cells(node) != 0)
> FAIL(c, dti, node, "incorrect #size-cells for SPI bus");
>
> The above code in check_spi_bus_bridge() require that the number of address
> cells must be 0. So we should explicitly declare "#address-cells = <0>".
>
> Signed-off-by: Zhen Lei <thunder.leizhen@xxxxxxxxxx>
> ---
> .../devicetree/bindings/spi/spi-controller.yaml | 20 ++++++++++++++------
> 1 file changed, 14 insertions(+), 6 deletions(-)
>
Applied, thanks!
Note that I tried fixing this in dtc, but that was rejected. So this
gets the schema in sync with dtc.
Rob