Re: [PATCH] mptcp: MPTCP_IPV6 should depend on IPV6 instead of selecting it

From: Jakub Kicinski
Date: Tue Oct 20 2020 - 23:58:45 EST


On Tue, 20 Oct 2020 11:26:34 +0200 Matthieu Baerts wrote:
> On 20/10/2020 09:38, Geert Uytterhoeven wrote:
> > MPTCP_IPV6 selects IPV6, thus enabling an optional feature the user may
> > not want to enable. Fix this by making MPTCP_IPV6 depend on IPV6, like
> > is done for all other IPv6 features.
>
> Here again, the intension was to select IPv6 from MPTCP but I understand
> the issue: if we enable MPTCP, we will select IPV6 as well by default.
> Maybe not what we want on some embedded devices with very limited memory
> where IPV6 is already off. We should instead enable MPTCP_IPV6 only if
> IPV6=y. LGTM then!
>
> Reviewed-by: Matthieu Baerts <matthieu.baerts@xxxxxxxxxxxx>

Applied, thanks!