Re: [PATCH] net: dsa: bcm_sf2: make const array static, makes object smaller
From: Jakub Kicinski
Date: Wed Oct 21 2020 - 00:00:16 EST
On Tue, 20 Oct 2020 09:51:39 -0700 Florian Fainelli wrote:
> On 10/20/20 9:50 AM, Colin King wrote:
> > From: Colin Ian King <colin.king@xxxxxxxxxxxxx>
> >
> > Don't populate the const array rate_table on the stack but instead it
> > static. Makes the object code smaller by 46 bytes.
> >
> > Before:
> > text data bss dec hex filename
> > 29812 3824 192 33828 8424 drivers/net/dsa/bcm_sf2.o
> >
> > After:
> > text data bss dec hex filename
> > 29670 3920 192 33782 83f6 drivers/net/dsa/bcm_sf2.o
> >
> > (gcc version 10.2.0)
> >
> > Signed-off-by: Colin Ian King <colin.king@xxxxxxxxxxxxx>
>
> Acked-by: Florian Fainelli <f.fainelli@xxxxxxxxx>
Applied, thanks!