Re: [PATCH 1/2] perf jevents: Tidy error handling

From: John Garry
Date: Thu Oct 22 2020 - 05:47:09 EST


On 21/10/2020 14:37, kajoljain wrote:
May be we can use similar checks:

if( verbose)
   pr_info("%s: Error walking file tree %s%s\n", prog, ldirname,err_string_ext);
if(rc > 0)
    empty_map = 1;
else
   ret = 1;

Not that it matters much, this logic is slightly different for verbose set and rc < 0. I don't mind going with that, so let me know.
Yes right. Sure if required we can made changes on these checks and include appropriate condition for verbose set and rc < 0. Seems fine to me.

I will just revert to the original logic for now. Someone can try to change later if they want.

Thanks