Re: [PATCH] mm,oom_kill: fix the comment of is_dump_unreclaim_slabs()

[Hui Su]

On Tue, Oct 27, 2020 at 08:11:18AM +0100, Michal Hocko wrote:
> On Sat 26-09-20 12:15:26, Hui Su wrote:
> > fix the comment of is_dump_unreclaim_slabs(), it just check
> > whether nr_unreclaimable slabs amount is greater than user
> > memory.
> 
> The original comment is meant to say when the function should be used.
> Your update makes the comment makes it a kerneldoc for an internal
> function which on its own is not very useful. It is quite clear what
> the function does. The intention is not clear anymore though.
> 
> If you find the comment confusing, however, then I would just propose either
> dropping it altogether or rename it to should_dump_unreclaimable_slab.
> Which is quite mouthful TBH.
>  

Hi, Michal:

Thanks for your explanation.

I also think maybe we should delete the comment, and change the rename it to
should_dump_unreclaimable_slabs().

Andrew,
Is that ok?