Re: [PATCH v1] pinctrl: intel: Add Intel Alder Lake pin controller support

From: Andy Shevchenko
Date: Thu Oct 29 2020 - 05:59:44 EST


On Thu, Oct 29, 2020 at 10:08:27AM +0200, Mika Westerberg wrote:

> I think the $subject should say "Alder Lake-S" as this is for -S
> variant.

OK!

...

> > @@ -158,4 +166,5 @@ config PINCTRL_TIGERLAKE
> > help
> > This pinctrl driver provides an interface that allows configuring
> > of Intel Tiger Lake PCH pins and using them as GPIOs.
> > +
>
> Is this intentional ws change?

I guess it was intentional at some point, but not strictly related to this new
driver. I can split it out.

> > endif
>
> Otherwise looks good to me.

I'll send v2 soon.

--
With Best Regards,
Andy Shevchenko