Re: [RESEND PATCH v3 1/4] dt-bindings: connector: add power-opmode optional property to usb-connector

[Amelie DELAUNAY]

On 10/29/20 4:40 PM, Rob Herring wrote:
> On Thu, Oct 29, 2020 at 10:58:03AM +0100, Amelie Delaunay wrote:
> > Power operation mode may depends on hardware design, so, add the optional
> > property power-opmode for usb-c connector to select the power operation
> > mode capability.
> >
> > Signed-off-by: Amelie Delaunay <amelie.delaunay@xxxxxx>
> > ---
> >   .../bindings/connector/usb-connector.yaml      | 18 ++++++++++++++++++
> >   1 file changed, 18 insertions(+)
> >
> > diff --git a/Documentation/devicetree/bindings/connector/usb-connector.yaml b/Documentation/devicetree/bindings/connector/usb-connector.yaml
> > index 728f82db073d..200d19c60fd5 100644
> > --- a/Documentation/devicetree/bindings/connector/usb-connector.yaml
> > +++ b/Documentation/devicetree/bindings/connector/usb-connector.yaml
> > @@ -93,6 +93,24 @@ properties:
> >         - device
> >         - dual
> >   
> > +  power-opmode:
>
> I've acked this version:
>
> https://lore.kernel.org/r/20201020093627.256885-2-badhri@xxxxxxxxxx

frs is used for Fast Role Swap defined in USB PD spec.
I understand it allows to get the same information but I'm wondering why 
the property name is limited to -frs- in this case. What about a 
non-power delivery USB-C connector ?

Moreover, power-opmode property support is already merged in typec class:
https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/commit/drivers/usb/typec/class.c?h=v5.10-rc1&id=12f3467b0d28369d3add7a0deb65fdac9b503c90
and stusb160x driver uses it :(

So, do I need to modify stusb160x driver (and bindings) to take into 
account this USB PD specific property?

Regards,
Amelie

> Please ack it if you are okay with it.
>
> Rob
>
>
> > +    description: Determines the power operation mode that the Type C connector
> > +      will support and will advertise through CC pins when it has no power
> > +      delivery support.
> > +      - "default" corresponds to default USB voltage and current defined by the
> > +        USB 2.0 and USB 3.2 specifications, 5V 500mA for USB 2.0 ports and
> > +        5V 900mA or 1500mA for USB 3.2 ports in single-lane or dual-lane
> > +        operation respectively.
> > +      - "1.5A" and "3.0A", 5V 1.5A and 5V 3.0A respectively, as defined in USB
> > +        Type-C Cable and Connector specification, when Power Delivery is not
> > +        supported.
> > +    allOf:
> > +      - $ref: /schemas/types.yaml#definitions/string
> > +    enum:
> > +      - default
> > +      - 1.5A
> > +      - 3.0A
> > +
> >     # The following are optional properties for "usb-c-connector" with power
> >     # delivery support.
> >     source-pdos:
> > --
> > 2.17.1