Re: [PATCH 29/42] drm/selftests/test-drm_dp_mst_helper: Place 'struct drm_dp_sideband_msg_req_body' onto the heap

[Lee Jones]

On Mon, 16 Nov 2020, Lyude Paul wrote:

> Huh-could have sworn I had reviewed this one already.
> 
> Reviewed-by: Lyude Paul <lyude@xxxxxxxxxx>

Yes, you're right.

It was masked by the discussion with Ville.  Apologies.

> On Mon, 2020-11-16 at 17:40 +0000, Lee Jones wrote:V
> > The stack is too full.
> > 
> > Fixes the following W=1 kernel build warning(s):
> > 
> >  drivers/gpu/drm/selftests/test-drm_dp_mst_helper.c: In function
> > ‘sideband_msg_req_encode_decode’:
> >  drivers/gpu/drm/selftests/test-drm_dp_mst_helper.c:161:1: warning: the
> > frame size of 1176 bytes is larger than 1024 bytes [-Wframe-larger-than=]
> > 
> > Cc: David Airlie <airlied@xxxxxxxx>
> > Cc: Daniel Vetter <daniel@xxxxxxxx>
> > Cc: Lyude Paul <lyude@xxxxxxxxxx>
> > Cc: David Francis <David.Francis@xxxxxxx>
> > Cc: dri-devel@xxxxxxxxxxxxxxxxxxxxx
> > Signed-off-by: Lee Jones <lee.jones@xxxxxxxxxx>
> > ---
> >  .../drm/selftests/test-drm_dp_mst_helper.c    | 31 ++++++++++++-------
> >  1 file changed, 20 insertions(+), 11 deletions(-)

-- 
Lee Jones [李琼斯]
Senior Technical Lead - Developer Services
Linaro.org │ Open source software for Arm SoCs
Follow Linaro: Facebook | Twitter | Blog