Re: [PATCH 1/7] mm,hwpoison: Refactor get_any_page
From: HORIGUCHI NAOYA(堀口 直也)
Date: Thu Nov 19 2020 - 20:33:39 EST
On Thu, Nov 19, 2020 at 11:57:10AM +0100, Oscar Salvador wrote:
> When we want to grab a refcount via get_any_page, we call
> __get_any_page that calls get_hwpoison_page to get the
> actual refcount.
> get_any_page is only there because we have a sort of retry
> mechanism in case the page we met is unknown to us or
> if we raced with an allocation.
>
> Also __get_any_page prints some messages about the page type
> in case the page was a free page or the page type was unknown,
> but if anything, we only need to print a message in case the
> pagetype was unknown, as that is reporting an error down the chain.
>
> Let us merge get_any_page and __get_any_page, and let the message
> be printed in soft_offline_page.
>
> Signed-off-by: Oscar Salvador <osalvador@xxxxxxx>
Looks good to me, thank you.
Acked-by: Naoya Horiguchi <naoya.horiguchi@xxxxxxx>