Re: [PATCH 084/141] drm/via: Fix fall-through warnings for Clang

From: Sam Ravnborg
Date: Sun Nov 22 2020 - 17:04:04 EST


On Fri, Nov 20, 2020 at 12:35:54PM -0600, Gustavo A. R. Silva wrote:
> In preparation to enable -Wimplicit-fallthrough for Clang, fix a warning
> by explicitly adding a break statement instead of letting the code fall
> through to the next case.
>
> Link: https://github.com/KSPP/linux/issues/115
> Signed-off-by: Gustavo A. R. Silva <gustavoars@xxxxxxxxxx>

Thanks, also applied to drm-misc-next.

Sam

> ---
> drivers/gpu/drm/via/via_irq.c | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/drivers/gpu/drm/via/via_irq.c b/drivers/gpu/drm/via/via_irq.c
> index 24cc445169e2..a3e0fb5b8671 100644
> --- a/drivers/gpu/drm/via/via_irq.c
> +++ b/drivers/gpu/drm/via/via_irq.c
> @@ -364,6 +364,7 @@ int via_wait_irq(struct drm_device *dev, void *data, struct drm_file *file_priv)
> irqwait->request.sequence +=
> atomic_read(&cur_irq->irq_received);
> irqwait->request.type &= ~_DRM_VBLANK_RELATIVE;
> + break;
> case VIA_IRQ_ABSOLUTE:
> break;
> default:
> --
> 2.27.0
>
> _______________________________________________
> dri-devel mailing list
> dri-devel@xxxxxxxxxxxxxxxxxxxxx
> https://lists.freedesktop.org/mailman/listinfo/dri-devel