Re: [PATCH 134/141] video: fbdev: lxfb_ops: Fix fall-through warnings for Clang
From: Sam Ravnborg
Date: Sun Nov 22 2020 - 17:05:46 EST
Hi Gustavo,
On Fri, Nov 20, 2020 at 12:40:32PM -0600, Gustavo A. R. Silva wrote:
> In preparation to enable -Wimplicit-fallthrough for Clang, fix a warning
> by explicitly adding a break statement instead of letting the code fall
> through to the next case.
>
> Link: https://github.com/KSPP/linux/issues/115
> Signed-off-by: Gustavo A. R. Silva <gustavoars@xxxxxxxxxx>
Thanks, applied this and the following patch to drm-misc-next.
Looks forward to have this warning enabled.
One can only wonder how many hours will be saved by lettting the
compiler tell you a break is missing. This is the kind of bugs you can
stare you blind at.
Sam