Re: [PATCH -next] usb: cdnsp: Mark cdnsp_gadget_ops with static keyword
From: Peter Chen
Date: Tue Dec 08 2020 - 21:41:22 EST
On 20-12-08 20:30:49, Zou Wei wrote:
> Fix the following sparse warning:
>
> drivers/usb/cdns3/cdnsp-gadget.c:1546:29: warning: symbol 'cdnsp_gadget_ops' was not declared. Should it be static?
>
> Signed-off-by: Zou Wei <zou_wei@xxxxxxxxxx>
> ---
> drivers/usb/cdns3/cdnsp-gadget.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/usb/cdns3/cdnsp-gadget.c b/drivers/usb/cdns3/cdnsp-gadget.c
> index 9716273..c7c5d0a 100644
> --- a/drivers/usb/cdns3/cdnsp-gadget.c
> +++ b/drivers/usb/cdns3/cdnsp-gadget.c
> @@ -1543,7 +1543,7 @@ static int cdnsp_gadget_pullup(struct usb_gadget *gadget, int is_on)
> return 0;
> }
>
> -const struct usb_gadget_ops cdnsp_gadget_ops = {
> +static const struct usb_gadget_ops cdnsp_gadget_ops = {
> .get_frame = cdnsp_gadget_get_frame,
> .wakeup = cdnsp_gadget_wakeup,
> .set_selfpowered = cdnsp_gadget_set_selfpowered,
> --
Applied, thanks.
--
Thanks,
Peter Chen