Re: [PATCH] spi: dt-bindings: clarify CS behavior for spi-cs-high and gpio descriptors

From: Sven Van Asbroeck
Date: Wed Dec 09 2020 - 12:37:34 EST


On Wed, Dec 9, 2020 at 4:57 AM H. Nikolaus Schaller <hns@xxxxxxxxxxxxx> wrote:
>
> +
> + device node | cs-gpio | CS pin state active | Note
> + ================+===============+=====================+=====
> + spi-cs-high | - | H |
> + - | - | L |
> + spi-cs-high | ACTIVE_HIGH | H |
> + - | ACTIVE_HIGH | L | 1
> + spi-cs-high | ACTIVE_LOW | H | 2
> + - | ACTIVE_LOW | L |
> +

Doesn't this table simply say:
- specify 'spi-cs-high' for an active-high chip select
- leave out 'spi-cs-high' for an active-low chip select
- the gpio active high/active low consumer flags are ignored
?

If so, then I would simply document it that way.
Simple is beautiful.