Re: [PATCH] thermal/drivers/devfreq: Fix missing dependency with the energy model
From: Stephen Rothwell
Date: Tue Dec 15 2020 - 03:49:05 EST
Hi Daniel,
On Tue, 15 Dec 2020 09:35:20 +0100 Daniel Lezcano <daniel.lezcano@xxxxxxxxxx> wrote:
>
> The devfreq cooling device has been converted to use the energy model.
>
> Add the dependency on the ENERGY_MODEL option to reflect this change
> and prevent build failure if the option is not set.
>
> Fixes: 615510fe13bd2 ("thermal: devfreq_cooling: remove old power model and use EM")
Reported-by: Stephen Rothwell <sfr@xxxxxxxxxxxxxxxx>
> Signed-off-by: Daniel Lezcano <daniel.lezcano@xxxxxxxxxx>
> ---
> drivers/thermal/Kconfig | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/drivers/thermal/Kconfig b/drivers/thermal/Kconfig
> index 7edc8dc6bbab..ee62d51ef351 100644
> --- a/drivers/thermal/Kconfig
> +++ b/drivers/thermal/Kconfig
> @@ -193,6 +193,7 @@ config DEVFREQ_THERMAL
> bool "Generic device cooling support"
> depends on PM_DEVFREQ
> depends on PM_OPP
> + depends on ENERGY_MODEL
> help
> This implements the generic devfreq cooling mechanism through
> frequency reduction for devices using devfreq.
Looks good to me.
--
Cheers,
Stephen Rothwell
Attachment:
pgpwhHH1owTI4.pgp
Description: OpenPGP digital signature