Re: [PATCH] thermal/drivers/devfreq: Fix missing dependency with the energy model

From: Lukasz Luba
Date: Tue Dec 15 2020 - 05:46:43 EST




On 12/15/20 8:48 AM, Stephen Rothwell wrote:
Hi Daniel,

On Tue, 15 Dec 2020 09:35:20 +0100 Daniel Lezcano <daniel.lezcano@xxxxxxxxxx> wrote:

The devfreq cooling device has been converted to use the energy model.

Add the dependency on the ENERGY_MODEL option to reflect this change
and prevent build failure if the option is not set.

Fixes: 615510fe13bd2 ("thermal: devfreq_cooling: remove old power model and use EM")

Reported-by: Stephen Rothwell <sfr@xxxxxxxxxxxxxxxx>

Signed-off-by: Daniel Lezcano <daniel.lezcano@xxxxxxxxxx>
---
drivers/thermal/Kconfig | 1 +
1 file changed, 1 insertion(+)

diff --git a/drivers/thermal/Kconfig b/drivers/thermal/Kconfig
index 7edc8dc6bbab..ee62d51ef351 100644
--- a/drivers/thermal/Kconfig
+++ b/drivers/thermal/Kconfig
@@ -193,6 +193,7 @@ config DEVFREQ_THERMAL
bool "Generic device cooling support"
depends on PM_DEVFREQ
depends on PM_OPP
+ depends on ENERGY_MODEL
help
This implements the generic devfreq cooling mechanism through
frequency reduction for devices using devfreq.

Looks good to me.


My apologies. I've tested it on odroidxu3 with
exynos_defconfig which has the energy model set.

Reviewed-by: Lukasz Luba <lukasz.luba@xxxxxxx>

Regards,
Lukasz