Re: [PATCH v2 3/4] spi: spi-geni-qcom: Don't try to set CS if an xfer is pending
From: Stephen Boyd
Date: Thu Dec 17 2020 - 21:52:37 EST
Quoting Doug Anderson (2020-12-17 13:35:08)
>
> If we wanted to truly make this driver super robust against ridiculous
> interrupt latencies then, presumably, we could handle the SPI timeout
> ourselves but before timing out we could check to see if the
> interrupts were pending. Then we could disable our interrupts,
> synchronize our interrupt handler, handle the interrupt directly, and
> then re-enable interrupts. If we did this then transfers could
> continue to eek their way through even if interrupts were completely
> blocked. IMO, it's not worth it. I'm satisfied with not crashing and
> not getting the state machine too out-of-whack.
>
Ok that's fair. If it's not worth the effort then let's drop this idea.