Re: [PATCH v8 1/4] dt-bindings: soc: imx8m: add DT Binding doc for soc unique ID

From: Krzysztof Kozlowski
Date: Fri Dec 18 2020 - 04:37:28 EST


On Fri, Dec 18, 2020 at 09:05:00AM +0000, Alice Guo (OSS) wrote:
> > + required:
> > > + - compatible
> > > + - nvmem-cells
> > > + - nvmem-cell-names
> > > +
> > > +additionalProperties: true
> >
> > Don't leave comments unresolved (or resolve them against review without
> > discussion). Rob asked for changing it. The same as with all schemas - you need
> > to describe the missing properties.
> >
> > Best regards,
> > Krzysztof
>
> Hi,
> Thank you for your advice. I replied to him and let him know I remained here unchanged. There will be errors according to his suggestion.

Then the solution is to correct the errors - describe missing properties
- instead of ignoring the suggestion and making a resubmit right away.

Best regards,
Krzysztof