RE: [PATCH] regmap: debugfs: fix a memory leak when calling regmap_attach_dev

[Wang, Xiaolei]

Hi Markus

> This should be caused by
> commit <9b947a13e7f6> ("<regmap: use debugfs even when no device>")

> I suggest to omit angle brackets from such information.


> * Will another imperative wording become helpful for the commit description?

> * How do you think about to add the tag “Fixes”?

Do you mean so?

commit:
         9b947a13e7f6 ("regmap: use debugfs even when no device")

…
> +++ b/drivers/base/regmap/regmap-debugfs.c
…
> @@ -582,8 +582,10 @@ void regmap_debugfs_init(struct regmap *map)
>  		devname = dev_name(map->dev);
>
>  	if (name) {
> -		map->debugfs_name = kasprintf(GFP_KERNEL, "%s-%s",
> +		if (!map->debugfs_name) {
> +			map->debugfs_name = kasprintf(GFP_KERNEL, "%s-%s",
>  					      devname, name);
> +		}
…

> I propose to add another null pointer check together with corresponding exception handling.

Which one do you mean by "another null point"? Do you mean that if the call "regmap_debugfs_init" function is repeated, it returns directly?

Regards,
Xiaolei



-----Original Message-----
From: Markus Elfring <Markus.Elfring@xxxxxx> 
Sent: Saturday, December 26, 2020 10:16 PM
To: Wang, Xiaolei <Xiaolei.Wang@xxxxxxxxxxxxx>; kernel-janitors@xxxxxxxxxxxxxxx
Cc: linux-kernel@xxxxxxxxxxxxxxx; Greg Kroah-Hartman <gregkh@xxxxxxxxxxxxxxxxxxx>; Mark Brown <broonie@xxxxxxxxxx>; Rafael J. Wysocki <rafael@xxxxxxxxxx>
Subject: Re: [PATCH] regmap: debugfs: fix a memory leak when calling regmap_attach_dev

> This should be caused by
> commit <9b947a13e7f6> ("<regmap: use debugfs even when no device>")

I suggest to omit angle brackets from such information.


* Will another imperative wording become helpful for the commit description?

* How do you think about to add the tag “Fixes”?


…
> +++ b/drivers/base/regmap/regmap-debugfs.c
…
> @@ -582,8 +582,10 @@ void regmap_debugfs_init(struct regmap *map)
>  		devname = dev_name(map->dev);
>
>  	if (name) {
> -		map->debugfs_name = kasprintf(GFP_KERNEL, "%s-%s",
> +		if (!map->debugfs_name) {
> +			map->debugfs_name = kasprintf(GFP_KERNEL, "%s-%s",
>  					      devname, name);
> +		}
…

I propose to add another null pointer check together with corresponding exception handling.

Regards,
Markus