Re: [PATCH v5 3/5] crypto: expose elliptic curve parameters as Crypto APIs

From: yumeng
Date: Mon Jan 04 2021 - 04:37:35 EST

在 2021/1/3 5:29, Herbert Xu 写道:
On Thu, Dec 24, 2020 at 02:08:25PM +0800, Meng Yu wrote:
Move elliptic curves definition to 'include/crypto/ecc_curve_defs.h',
so all can use it,

Signed-off-by: Meng Yu <yumeng18@xxxxxxxxxx>
Reviewed-by: Zaibo Xu <xuzaibo@xxxxxxxxxx>
crypto/ecc.c | 1 -
crypto/ecc.h | 37 +----------------
crypto/ecc_curve_defs.h | 57 -------------------------
crypto/ecrdsa_defs.h | 2 +-
include/crypto/ecc_curve_defs.h | 92 +++++++++++++++++++++++++++++++++++++++++
5 files changed, 95 insertions(+), 94 deletions(-)
delete mode 100644 crypto/ecc_curve_defs.h
create mode 100644 include/crypto/ecc_curve_defs.h

This conflicts with

Please discuss with each other on how you would like to proceed.


hello, Daniele,

In my patch, I move elliptic curves definition to 'include/crypto/ecc_curve_defs.h',
which include the P-384 curve you need, and you can easily import it to your driver.

And if you include 'crypto/ecc_curve_defs.h', 'drivers/crypto/keembay/ocs-ecc-curve-defs.h'
is not needed.

Could you think about it, to rely on my patchset?