Re: [PATCH v2 10/18] ARM: dts: qcom: sdx55: Add QPIC NAND support

From: Manivannan Sadhasivam
Date: Wed Jan 06 2021 - 02:30:36 EST


On Tue, Jan 05, 2021 at 09:21:02PM +0530, Vinod Koul wrote:
> On 05-01-21, 17:56, Manivannan Sadhasivam wrote:
> > Add qpic_nand node to support QPIC NAND controller on SDX55 platform.
> > Since there is no "aon" clock in SDX55, a dummy clock is provided.
> >
> > Signed-off-by: Manivannan Sadhasivam <manivannan.sadhasivam@xxxxxxxxxx>
> > ---
> > arch/arm/boot/dts/qcom-sdx55.dtsi | 22 ++++++++++++++++++++++
> > 1 file changed, 22 insertions(+)
> >
> > diff --git a/arch/arm/boot/dts/qcom-sdx55.dtsi b/arch/arm/boot/dts/qcom-sdx55.dtsi
> > index 1b9b990ad0a2..1a6947753972 100644
> > --- a/arch/arm/boot/dts/qcom-sdx55.dtsi
> > +++ b/arch/arm/boot/dts/qcom-sdx55.dtsi
> > @@ -41,6 +41,12 @@ pll_test_clk: pll-test-clk {
> > #clock-cells = <0>;
> > clock-frequency = <400000000>;
> > };
> > +
> > + nand_clk_dummy: nand-clk-dummy {
>
> Why dummy..?

There is no such clock used on this platform but the driver requires it.

> > + compatible = "fixed-clock";
> > + #clock-cells = <0>;
> > + clock-frequency = <32000>;
>
> Is this sleep clock of platform..?
>

Always ON (AON) clock.

Thanks,
Mani