Re: [PATCH v2 04/11] perf c2c: Rename for shared cache line stats
From: Namhyung Kim
Date: Wed Jan 06 2021 - 02:45:33 EST
On Sun, Dec 13, 2020 at 10:39 PM Leo Yan <leo.yan@xxxxxxxxxx> wrote:
>
> For shared cache line statistics, it relies on HITM. We can use more
> general naming rather than only binding to HITM, so replace "hitm_stats"
> with "shared_clines_stats" in structure perf_c2c, and rename function
> resort_hitm_cb() to resort_shared_cl_cb().
>
> Signed-off-by: Leo Yan <leo.yan@xxxxxxxxxx>
> ---
> tools/perf/builtin-c2c.c | 14 +++++++-------
> 1 file changed, 7 insertions(+), 7 deletions(-)
>
> diff --git a/tools/perf/builtin-c2c.c b/tools/perf/builtin-c2c.c
> index 27745340c14a..580c4ead68db 100644
> --- a/tools/perf/builtin-c2c.c
> +++ b/tools/perf/builtin-c2c.c
> @@ -97,8 +97,8 @@ struct perf_c2c {
> bool symbol_full;
> bool stitch_lbr;
>
> - /* HITM shared clines stats */
> - struct c2c_stats hitm_stats;
> + /* Shared clines stats */
Please change it to "Shared cache line stats".
Thanks,
Namhyung
> + struct c2c_stats shared_clines_stats;
> int shared_clines;
>
> int display;