Re: [PATCH V3] clk: imx: Fix reparenting of UARTs not associated with sdout

From: Abel Vesa
Date: Wed Jan 20 2021 - 10:30:06 EST


On 21-01-20 16:13:05, Sascha Hauer wrote:
> Hi Abel,
>
> On Wed, Jan 20, 2021 at 04:44:54PM +0200, Abel Vesa wrote:
> > On 21-01-18 08:00:43, Adam Ford wrote:
> > > On Mon, Jan 18, 2021 at 6:52 AM Abel Vesa <abel.vesa@xxxxxxx> wrote:

...

> > >
> > > >
> > > > TBH, I'm against the idea of having to call consumer API from a clock provider driver.
> > > > I'm still investigating a way of moving the uart clock control calls in drivers/serial/imx,
> > > > where they belong.
> > >
> > > That makes sense.
> > >
> >
> > Just a thought. The uart clock used for console remains on from u-boot,
> > so maybe it's enough to just add the CLK_IGNORE_UNUSED flag to all the
> > uart root clocks and remove the prepare/enable calls for uart clocks
> > for good. I don't really have a way to test it right now, but maybe
> > you could give it a try.
>
> That would mean that UART clocks will never be disabled, regardless of
> whether they are used for console or not. That doesn't sound very
> appealing.

AFAIK, the only uart clock that is enabled by u-boot is the one used for
the console. Later on, when the serial driver probes, it will enable it itself.

Unless I'm missing something, this is exactly what we need.