Re: [PATCH] of: property: Add device link support for interrupts
From: Saravana Kannan
Date: Wed Jan 20 2021 - 12:17:57 EST
On Wed, Jan 20, 2021 at 6:28 AM Geert Uytterhoeven <geert@xxxxxxxxxxxxxx> wrote:
> Hi Saravana,
> On Wed, Jan 20, 2021 at 10:53 AM Geert Uytterhoeven
> <geert@xxxxxxxxxxxxxx> wrote:
> > On Fri, Dec 18, 2020 at 10:11 PM Saravana Kannan <saravanak@xxxxxxxxxx> wrote:
> > > Add support for creating device links out of interrupts property.
> > >
> > > Cc: Marc Zyngier <maz@xxxxxxxxxx>
> > > Cc: Kevin Hilman <khilman@xxxxxxxxxxxx>
> > > Signed-off-by: Saravana Kannan <saravanak@xxxxxxxxxx>
> > Thanks for your patch!
> > This does not seem to add all links. I see links being created to the
> > secondary interrupt controller (e61c0000 "renesas,irqc"), but not to
> > the primary interrupt controller (GIC)
> > Which is good, as the GIC driver is not a platform_driver, and thus
> > creating links would break everything ;-)
> of_link_to_phandle() ignores device nodes where OF_POPULATED
> is set, and of_irq_init() sets that flag. Hence the GIC is ignored.
Yes, I know :) I wrote it that way for GIC and some of the early
devices that can't use the driver core. And as Marc said in the other
email, it looks like GIC is going to be stuck as a non-device for a
while. But this patch and others that'll follow are all set up for
allowing non-root interrupt controllers to be implemented as platform
devices (or <anybus> device).