Re: [PATCH 1/2] dt-bindings: interconnect: Add Qualcomm SM8350 DT bindings

[Vinod Koul]

Hi Gerogi,

On 10-02-21, 13:30, Georgi Djakov wrote:

> > +#define SM8350_MASTER_LLCC_DISP				1000
> > +#define SM8350_MASTER_MNOC_HF_MEM_NOC_DISP		1001
> > +#define SM8350_MASTER_MNOC_SF_MEM_NOC_DISP		1002
> > +#define SM8350_MASTER_MDP0_DISP				1003
> > +#define SM8350_MASTER_MDP1_DISP				1004
> > +#define SM8350_MASTER_ROTATOR_DISP			1005
> > +#define SM8350_SLAVE_EBI1_DISP				1512
> > +#define SM8350_SLAVE_LLCC_DISP				1513
> > +#define SM8350_SLAVE_MNOC_HF_MEM_NOC_DISP		1514
> > +#define SM8350_SLAVE_MNOC_SF_MEM_NOC_DISP		1515
> 
> Why are you using these big numbers? They are used as array indexes
> and we will be wasting a lot of memory for unnecessary large arrays.

Thanks for the explanation, yes that would be the case. I will split it
up and send v2

-- 
~Vinod