Re: [PATCH] module: potential uninitialized return in module_kallsyms_on_each_symbol()

From: Miroslav Benes
Date: Wed Feb 10 2021 - 07:13:21 EST


On Wed, 10 Feb 2021, Dan Carpenter wrote:

> Smatch complains that:
>
> kernel/module.c:4472 module_kallsyms_on_each_symbol()
> error: uninitialized symbol 'ret'.
>
> This warning looks like it could be correct if the &modules list is
> empty.
>
> Fixes: 013c1667cf78 ("kallsyms: refactor {,module_}kallsyms_on_each_symbol")
> Signed-off-by: Dan Carpenter <dan.carpenter@xxxxxxxxxx>

Reviewed-by: Miroslav Benes <mbenes@xxxxxxx>

M