Re: [GIT PULL 5.11-rc8] LED fix

From: Pavel Machek
Date: Sun Feb 14 2021 - 15:37:08 EST


Hi!

> > Unfortunately, for some reason request-pull is not willing to
> > cooperate, so I'm just doing this manually.
>
> The reason request-pull doesn't cooperate is actually spelled out explicitly:
>
> > pavel@duo:/data/l/linux-leds$ git request-pull master git://git.kernel.org/pub/scm/linux/kernel/git/pavel/linux-leds.git/ 92bf22614b21a2706f4993b278017e437f7785b3 > /tmp/delme for-rc8-5.11
> > warn: No match for commit 92bf22614b21a2706f4993b278017e437f7785b3 found at git://git.kernel.org/pub/scm/linux/kernel/git/pavel/linux-leds.git/
> > warn: Are you sure you pushed '92bf22614b21a2706f4993b278017e437f7785b3' there?
>
> Commit 92bf22614b21 is my rc7 commit. And it's not in your tree (which
> is based on rc1).
>
> Why are you giving raw commit ID's to git request-pull? Particularly
> ones that aren't even in your upstream tree? Git figures things out on
> its own, why do you point to the rc7 commit that has nothing to do
> with what you're pushing?

I find raw commit IDs easier to work with than the tags.

> And yes, that commit exists on kernel.org through my tree, but it's
> not reachable from any tips in yours (because your work was based on
> earlier state - which is as it should be).

I don't understand.

I want you to apply dbeb02a0bc41b9e9b9c05e460890351efecf1352 .

92bf22614b21 is my rc7, and it is parent of the commit I want you to
apply. It is listed as so on
https://git.kernel.org/pub/scm/linux/kernel/git/pavel/linux-leds.git/commit/?h=for-rc8-5.11 . I would call that "reachable"...?

So I guess I could update master to rc7 to get rid of this error and
retry request-pull?

Best regards,
Pavel
--
http://www.livejournal.com/~pavelmachek

Attachment: signature.asc
Description: Digital signature