Re: [git pull] sendfile fixes

From: Al Viro
Date: Sun Feb 14 2021 - 16:19:13 EST


On Sun, Feb 14, 2021 at 11:35:36AM -0800, Linus Torvalds wrote:

> Just to clarify: this says "fixes", but I get the feeling that you
> meant for me to pull tomorrow in the 5.12 merge window?
>
> I like the patches, but they don't seem to be anything hugely urgent.
> They should make "sendfile to pipe" more efficient, but the current
> hack is _workable_ (and not any worse than what we historically did)
> even if it's not optimal.
>
> Right?

Yes. It allows to drop the current hack, but it's not urgent.

> Oh, and it looks like the first line of the commit message of
> 313d64a35d36 ("do_splice_to(): move the logics for limiting the read
> length in") got truncated somehow..

Offense against style, actually - preposition torn from object and
moved to the very end of sentence... "[splice] move the logics for limiting
the read length into do_splice_to()" would probably be better.