Re: [PATCH] bus: mhi: core: Use current ee in intvec handler for syserr
From: Loic Poulain
Date: Mon Feb 15 2021 - 02:14:57 EST
On Sat, 13 Feb 2021 at 01:41, Jeffrey Hugo <jhugo@xxxxxxxxxxxxxx> wrote:
>
> The intvec handler stores the caches ee in a local variable for use in
> processing the intvec. When determining if a syserr is a fatal error or
> not, the intvec handler is using the cached version, when it should be
> using the current ee read from the device. Currently, the device could
> be in the PBL ee as the result of a fatal error, but the cached ee might
> be AMSS, which would cause the intvec handler to incorrectly signal a
> non-fatal syserr.
>
> Fixes: 3000f85b8f47 ("bus: mhi: core: Add support for basic PM operations")
> Signed-off-by: Jeffrey Hugo <jhugo@xxxxxxxxxxxxxx>
So in that function, 'ee' should be 'previous_ee', right?
Reviewed-by: Loic Poulain <loic.poulain@xxxxxxxxxx>