Re: [PATCH v2] leds: apu: extend support for PC Engines APU1 with newer firmware
From: Pavel Machek
Date: Fri Feb 19 2021 - 06:26:10 EST
> > MODULE_DEVICE_TABLE(dmi, apu_led_dmi_table);
> > @@ -173,7 +182,7 @@ static int __init apu_led_init(void)
> > int err;
> > if (!(dmi_match(DMI_SYS_VENDOR, "PC Engines") &&
> > - dmi_match(DMI_PRODUCT_NAME, "APU"))) {
> > + (dmi_match(DMI_PRODUCT_NAME, "APU") || dmi_match(DMI_PRODUCT_NAME, "apu1")))) {
> > pr_err("No PC Engines APUv1 board detected. For APUv2,3 support, enable CONFIG_PCENGINES_APU2\n");
> > return -ENODEV;
> > }
> >
>
> Looks good to me. But don't dare giving official ack, since I don't
> have an apu1 board for testing.
>
> Is Alan Mizrahi (original author) still here ?
People are usually not that careful with thier acks.
Applied, thanks.
BR,
Pavel
--
http://www.livejournal.com/~pavelmachek
Attachment:
signature.asc
Description: PGP signature