Re: [PATCH v4] rtc: rx6110: add ACPI bindings to I2C

[Claudius Heine]

Hi Andy,

On 2021-03-16 17:55, Andy Shevchenko wrote:
> On Tue, Mar 16, 2021 at 03:48:18PM +0100, Claudius Heine wrote:
> > From: Johannes Hahn <johannes-hahn@xxxxxxxxxxx>
> >
> > This allows the RX6110 driver to be automatically assigned to the right
> > device on the I2C bus.
>
> You missed given tag, when somebody sends you one, it's usually your
> responsibility to pick it up. Hint: install b4 tool (likely in your distro, at
> least Debian, Arch Linux have it) and run it against message ID of the version
> in question. It will gather all tags. For example, for this case, run
>
>    % b4 am 20210316144819.4130622-1-ch@xxxxxxx
>
> It will download mailbox suitable for `git am ...` you will read on the screen.
>
> Also, when send a new version, don't attach it to the old thread. It will
> confuse people and maybe even tools (i.o.w. don't supply message ID to be put
> to In-Reply-To header).

Ok.

> So, repeat again my tag and see one fix to be performed below.
> Reviewed-by: From: Andy Shevchenko <andriy.shevchenko@xxxxxxxxxxxxxxx>

Ok, will take care about this in v5.

> > Signed-off-by: Johannes Hahn <johannes-hahn@xxxxxxxxxxx>
> > Co-developed-by: Claudius Heine <ch@xxxxxxx>
> > Signed-off-by: Claudius Heine <ch@xxxxxxx>
> > ---
> >   drivers/rtc/rtc-rx6110.c | 7 +++++++
> >   1 file changed, 7 insertions(+)
> >
> > diff --git a/drivers/rtc/rtc-rx6110.c b/drivers/rtc/rtc-rx6110.c
> > index 79161d4c6ce4..2a06953c0a84 100644
> > --- a/drivers/rtc/rtc-rx6110.c
> > +++ b/drivers/rtc/rtc-rx6110.c
> > @@ -447,6 +447,12 @@ static int rx6110_i2c_probe(struct i2c_client *client,
> >   	return rx6110_probe(rx6110, &client->dev);
> >   }
> >   
> > +static const struct acpi_device_id rx6110_i2c_acpi_match[] = {
> > +	{ "SECC6110" },
> > +	{ }
> > +};
> > +MODULE_DEVICE_TABLE(acpi, rx6110_i2c_acpi_match);
> > +
> >   static const struct i2c_device_id rx6110_i2c_id[] = {
> >   	{ "rx6110", 0 },
> >   	{ }
> > @@ -456,6 +462,7 @@ MODULE_DEVICE_TABLE(i2c, rx6110_i2c_id);
> >   static struct i2c_driver rx6110_i2c_driver = {
> >   	.driver = {
> >   		.name = RX6110_DRIVER_NAME,
> > +		.acpi_match_table = ACPI_PTR(rx6110_i2c_acpi_match),
>
> Since you drop ifdeffery above, you have to drop ACPI_PTR() (besides that
> ACPI_PTR() requires acpi.h to be included).

Ok, will do that as well.

regards,
Claudius