Re: [PATCH 1/4] dt-bindings: mmc: iproc-sdhci: Convert to json-schema
From: Scott Branden
Date: Wed Mar 24 2021 - 12:44:55 EST
On 2021-03-24 9:35 a.m., Nicolas Saenz Julienne wrote:
> On Wed, 2021-03-24 at 09:27 -0700, Scott Branden wrote:
>> On 2021-03-23 2:24 p.m., Nicolas Saenz Julienne wrote:
>>> On Tue, 2021-03-23 at 15:08 -0600, Rob Herring wrote:
>>>> On Mon, Mar 22, 2021 at 12:11:29PM -0700, Scott Branden wrote:
>>>>> On 2021-03-22 11:58 a.m., Nicolas Saenz Julienne wrote:
>>>>>> Convert the brcm,iproc-sdhci binding to DT schema format using json-schema
>>>>>>
>>>>>> Signed-off-by: Nicolas Saenz Julienne <nsaenz@xxxxxxxxxx>
>>>>>> ---
>>>>>> .../bindings/mmc/brcm,iproc-sdhci.yaml | 58 +++++++++++++++++++
>>>>>> .../bindings/mmc/brcm,sdhci-iproc.txt | 37 ------------
>>>>>> 2 files changed, 58 insertions(+), 37 deletions(-)
>>>>>> create mode 100644 Documentation/devicetree/bindings/mmc/brcm,iproc-sdhci.yaml
>>>>>> delete mode 100644 Documentation/devicetree/bindings/mmc/brcm,sdhci-iproc.txt
>>>>>>
>>>>>> diff --git a/Documentation/devicetree/bindings/mmc/brcm,iproc-sdhci.yaml b/Documentation/devicetree/bindings/mmc/brcm,iproc-sdhci.yaml
>>>>>> new file mode 100644
>>>>>> index 000000000000..19d84f3ef9e6
>>>>>> --- /dev/null
>>>>>> +++ b/Documentation/devicetree/bindings/mmc/brcm,iproc-sdhci.yaml
>>>>>> @@ -0,0 +1,58 @@
>>>>>> +# SPDX-License-Identifier: GPL-2.0
>>>>>> +%YAML 1.2
>>>>>> +---
>>>>>> +$id: http://devicetree.org/schemas/mmc/brcm,iproc-sdhci.yaml#
>>>>>> +$schema: http://devicetree.org/meta-schemas/core.yaml#
>>>>>> +
>>>>>> +title: Broadcom IPROC SDHCI controller
>>>>>> +
>>>>>> +maintainers:
>>>>>> + - Nicolas Saenz Julienne <nsaenz@xxxxxxxxxx>
>>>>> This is already covered in the MAINTAINERS section via "N: iproc".
>>>>> M: Ray Jui <ray.jui@xxxxxxxxxxxx>
>>>>>
>>>>> M: Scott Branden <scott.branden@xxxxxxxxxxxx>
>>>>>
>>>>> M: bcm-kernel-feedback-list@xxxxxxxxxxxx
>>>>
>>>> Maybe so, but still required here. The problem is there is no
>>>> MAINTAINERS file in the DT only tree[1].
>>>
>>> Well in that case, if Scott and Ray are OK with it I'll add them.
>> I do not know what the "maintainers" section in the yaml file is used to indicate.
>> If it is maintainer for the driver then please add the duplicate of what is
>> already in the MAINTAINERS file. If it is for maintainer of devicetrees that
>> use this driver then no need to add us.
>
> From the dt bindings documentation:
>
> maintainers
> A DT specific property. Contains a list of email address(es)
> for maintainers of this binding.
>
> That's the maintainers for the bindings, not the devicetrees consuming them. I
> belive it makes sense for you guys to maintain it as it has a strong
> relationship to driver changes. But if you're not interested I'll do it myself.
Sure, you can add us as well.
>
> Regards,
> Nicolas
>
Attachment:
smime.p7s
Description: S/MIME Cryptographic Signature